<html>
<head><meta charset="utf-8"><title>Frames Iterator PR · project-error-handling · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/index.html">project-error-handling</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html">Frames Iterator PR</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="220401404"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220401404" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220401404">(Dec 18 2020 at 17:19)</a>:</h4>
<p>If anyone has additional bandwidth, I could use a second pair of eyes on the frames iterator PR I'm working through: <a href="https://github.com/rust-lang/rust/pull/78299">https://github.com/rust-lang/rust/pull/78299</a></p>



<a name="220401499"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220401499" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220401499">(Dec 18 2020 at 17:19)</a>:</h4>
<p>I'm currently trying to implement <code>Iterator</code> for the <code>Frames</code> type, but I'm running into an issue with how I'm specifying the <code>Iterator</code>'s <code>type</code>.</p>



<a name="220401908"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220401908" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220401908">(Dec 18 2020 at 17:22)</a>:</h4>
<p>Here's the actual error I'm getting: <a href="/user_uploads/4715/C-Uj8aMp5LNELK3BGStaG4bM/Screen-Shot-2020-12-18-at-11.21.36-AM.png">Screen-Shot-2020-12-18-at-11.21.36-AM.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/C-Uj8aMp5LNELK3BGStaG4bM/Screen-Shot-2020-12-18-at-11.21.36-AM.png" title="Screen-Shot-2020-12-18-at-11.21.36-AM.png"><img src="/user_uploads/4715/C-Uj8aMp5LNELK3BGStaG4bM/Screen-Shot-2020-12-18-at-11.21.36-AM.png"></a></div>



<a name="220402539"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220402539" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220402539">(Dec 18 2020 at 17:27)</a>:</h4>
<p>I'm confused why the compiler thinks this is specialized</p>



<a name="220402545"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220402545" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220402545">(Dec 18 2020 at 17:28)</a>:</h4>
<p>is there more to the error?</p>



<a name="220402655"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220402655" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220402655">(Dec 18 2020 at 17:28)</a>:</h4>
<p>oh you specified Item twice</p>



<a name="220402672"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220402672" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220402672">(Dec 18 2020 at 17:28)</a>:</h4>
<p>you only need to specify it for Iterator, not IntoITerator, I think</p>



<a name="220420237"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220420237" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220420237">(Dec 18 2020 at 19:50)</a>:</h4>
<p>Hm, I still get a similar error, it's just now pointing at the <code>type IntoIter</code> declaration: <a href="/user_uploads/4715/S5AimlxjJk0-JpM0hsFHwgh3/Screen-Shot-2020-12-18-at-1.48.36-PM.png">Screen-Shot-2020-12-18-at-1.48.36-PM.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/S5AimlxjJk0-JpM0hsFHwgh3/Screen-Shot-2020-12-18-at-1.48.36-PM.png" title="Screen-Shot-2020-12-18-at-1.48.36-PM.png"><img src="/user_uploads/4715/S5AimlxjJk0-JpM0hsFHwgh3/Screen-Shot-2020-12-18-at-1.48.36-PM.png"></a></div>



<a name="220420263"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220420263" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220420263">(Dec 18 2020 at 19:50)</a>:</h4>
<p>Even if I remove that line, it still complains about the same thing.</p>



<a name="220421520"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220421520" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220421520">(Dec 18 2020 at 20:01)</a>:</h4>
<p>anything that is an iterator is also an <code>IntoIterator</code>: <a href="https://doc.rust-lang.org/stable/core/iter/trait.IntoIterator.html#impl-IntoIterator-8">https://doc.rust-lang.org/stable/core/iter/trait.IntoIterator.html#impl-IntoIterator-8</a></p>



<a name="220421563"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220421563" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220421563">(Dec 18 2020 at 20:01)</a>:</h4>
<p>So implementing both <code>Iterator</code> and <code>IntoIterator</code> would be specializing the linked impl.</p>



<a name="220421663"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220421663" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220421663">(Dec 18 2020 at 20:02)</a>:</h4>
<p>Ah, so just implementing <code>Iterator</code> is enough?</p>



<a name="220421738"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220421738" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220421738">(Dec 18 2020 at 20:03)</a>:</h4>
<p>Depends on what you're looking to achieve. I've no context here.</p>



<a name="220421784"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220421784" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220421784">(Dec 18 2020 at 20:03)</a>:</h4>
<p>It is plausible that you might want <code>IntoIterator</code> and not <code>Iterator</code> directly (much like vector or slice don't implement <code>Iterator</code> directly)</p>



<a name="220421895"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220421895" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220421895">(Dec 18 2020 at 20:04)</a>:</h4>
<p>my guess is that this is the type returned by the <code>frames</code> fn, which is supposed to be an <code>Iterator</code> already</p>



<a name="220421936"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220421936" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220421936">(Dec 18 2020 at 20:04)</a>:</h4>
<p>let me double check that vec::Iter is an iterator and not intoiter</p>



<a name="220421983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220421983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220421983">(Dec 18 2020 at 20:05)</a>:</h4>
<p>ye</p>



<a name="220422013"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220422013" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220422013">(Dec 18 2020 at 20:05)</a>:</h4>
<p>The <code>Frames</code> type wraps a <code>Frames::inner</code> field, which is what is holding the <code>Vec&lt;BacktraceFrame&gt;</code>s</p>



<a name="220422086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220422086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220422086">(Dec 18 2020 at 20:06)</a>:</h4>
<p>hmmm</p>



<a name="220422116"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220422116" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220422116">(Dec 18 2020 at 20:06)</a>:</h4>
<p>So I thought I would need to implement <code>Iterator</code> for the <code>Frames</code> type to expose the <code>Vec&lt;BacktraceFrame&gt;</code>s as an iterator.</p>



<a name="220422138"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220422138" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220422138">(Dec 18 2020 at 20:06)</a>:</h4>
<p>aah you implemented Iterator as just pop</p>



<a name="220422180"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220422180" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220422180">(Dec 18 2020 at 20:06)</a>:</h4>
<p>Yea, I'm also now sure popping is what we want here to yield the frames in the desired order.</p>



<a name="220422183"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220422183" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220422183">(Dec 18 2020 at 20:06)</a>:</h4>
<p>I'm assuming that is fine</p>



<a name="220422217"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220422217" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220422217">(Dec 18 2020 at 20:07)</a>:</h4>
<p>I feel like a <code>VecDeque</code> and popping from the front would make more sense</p>



<a name="220422231"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/220422231" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#220422231">(Dec 18 2020 at 20:07)</a>:</h4>
<p>But I'm not sure</p>



<a name="221708374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221708374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221708374">(Jan 05 2021 at 22:08)</a>:</h4>
<p>Is anyone familiar with <code>std::lazy::SyncLazy</code>? <span class="user-mention" data-user-id="204346">@Ashley Mannix</span> suggested that it be used to replace the <code>Mutex</code> around captured backtraces:</p>
<div class="codehilite"><pre><span></span><code>// in backtrace.rs
enum Inner {
  Unsupported,
  Disabled,
  Captured(Mutex&lt;Capture&gt;),
}
</code></pre></div>
<p>The <code>Captured(Mutex&lt;Capture&gt;)</code> would be changed to <code>Captured(SyncLazy&lt;Capture&gt;)</code>. </p>
<p>Is <code>SyncLazy</code> basically a lazy <code>Mutex</code>? I'm also not really sure how to use its API to replace the calls to <code>capture.lock()</code> where we acquire the <code>Capture</code> inside the <code>Mutex</code>. Anyone have insight into this?</p>



<a name="221708434"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221708434" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221708434">(Jan 05 2021 at 22:08)</a>:</h4>
<p><span class="user-mention" data-user-id="300743">@Sean Chen</span> im guessing its like a mutex that doesnt have an <code>&amp;mut T</code> api</p>



<a name="221708440"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221708440" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221708440">(Jan 05 2021 at 22:08)</a>:</h4>
<p>so it can only either be initialized or accessed</p>



<a name="221708484"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221708484" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221708484">(Jan 05 2021 at 22:09)</a>:</h4>
<p>i'm not positive but I think that's the new <code>once_cell</code> built into std</p>



<a name="221708622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221708622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221708622">(Jan 05 2021 at 22:10)</a>:</h4>
<p>Oh, so we'd replace any <code>captured.lock()</code> calls with calls to the <code>SyncLazy::force</code> method to access the type inside?</p>



<a name="221708657"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221708657" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221708657">(Jan 05 2021 at 22:10)</a>:</h4>
<p>not sure</p>



<a name="221708683"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221708683" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221708683">(Jan 05 2021 at 22:10)</a>:</h4>
<p>i'll have to look at the API, in a meeting atm</p>



<a name="221708787"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221708787" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221708787">(Jan 05 2021 at 22:11)</a>:</h4>
<p><span class="user-mention" data-user-id="300743">@Sean Chen</span> that, or just dereference it; it Derefs to Capture</p>



<a name="221708845"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221708845" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221708845">(Jan 05 2021 at 22:11)</a>:</h4>
<p>looks like yea</p>



<a name="221708849"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221708849" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221708849">(Jan 05 2021 at 22:11)</a>:</h4>
<p>oh</p>



<a name="221708851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221708851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221708851">(Jan 05 2021 at 22:11)</a>:</h4>
<p>^</p>



<a name="221709409"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221709409" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221709409">(Jan 05 2021 at 22:17)</a>:</h4>
<p>you can sort of imagine it as a <code>RwLock</code> that's specialized to only ever have one write</p>



<a name="221711012"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221711012" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Ashley Mannix <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221711012">(Jan 05 2021 at 22:35)</a>:</h4>
<p>Ah yeh, that suggestion was based on an assumption that we only lock the capture to do some kind of deferred initialization work. With <code>SyncLazy</code> we can still initialize lazily, but also deref as normal and return borrows to those frames without needing any locks. It would avoid having to do any cloning</p>



<a name="221711038"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221711038" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Ashley Mannix <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221711038">(Jan 05 2021 at 22:35)</a>:</h4>
<p>But I should look at the backtrace impl properly to see if that’s actually the case 🙂</p>



<a name="221711097"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221711097" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221711097">(Jan 05 2021 at 22:36)</a>:</h4>
<p><span class="user-mention" data-user-id="204346">@Ashley Mannix</span> i moved your message to a diff topic</p>



<a name="221711139"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221711139" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221711139">(Jan 05 2021 at 22:36)</a>:</h4>
<p>assuming it was meant for this one</p>



<a name="221711275"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221711275" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Ashley Mannix <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221711275">(Jan 05 2021 at 22:38)</a>:</h4>
<p>Yep thanks <span aria-label="pray" class="emoji emoji-1f64f" role="img" title="pray">:pray:</span><span aria-label="big smile" class="emoji emoji-1f604" role="img" title="big smile">:big_smile:</span> I’m on mobile and thought I was in the right one</p>



<a name="221711997"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221711997" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Ashley Mannix <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221711997">(Jan 05 2021 at 22:46)</a>:</h4>
<p>Ok, so we lock the capture to call the <code>resolve</code> method. It might be slightly tricky to make the current <code>SyncLazy</code> API do that, but it should be possible with a regular old <code>sync::Once</code>. <span class="user-mention" data-user-id="300743">@Sean Chen</span> I can put together a quick patch now to show you what I mean if you like <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="221712146"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221712146" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221712146">(Jan 05 2021 at 22:48)</a>:</h4>
<p>That would be helpful <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="221720245"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/221720245" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Ashley Mannix <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#221720245">(Jan 06 2021 at 00:20)</a>:</h4>
<p><span class="user-mention" data-user-id="300743">@Sean Chen</span> I ended up opening <a href="https://github.com/rust-lang/rust/pull/80736">https://github.com/rust-lang/rust/pull/80736</a> <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="222638044"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222638044" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222638044">(Jan 13 2021 at 20:07)</a>:</h4>
<p>So I made the classic mistake of not implementing the changes in a feature branch separate from my local master branch. I <code>git pull</code>ed into my local master (where I've been making all my changes as part of this PR) to merge in <span class="user-mention" data-user-id="204346">@Ashley Mannix</span>'s changes and fixed a merge conflict. </p>
<p>Am I good to push these changes to my fork? Or do I need to rebase against upstream master?</p>



<a name="222641256"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222641256" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222641256">(Jan 13 2021 at 20:32)</a>:</h4>
<p><span class="user-mention" data-user-id="300743">@Sean Chen</span> merging and rebasing are normally second, I would be hesistant to do both</p>



<a name="222641866"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222641866" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222641866">(Jan 13 2021 at 20:36)</a>:</h4>
<p>Hm, so what should I be doing instead? I want to incorporate Ashley's merged PR into mine, but I also am working from my fork's <code>master</code> branch instead of in a separate feature branch.</p>



<a name="222641956"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222641956" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222641956">(Jan 13 2021 at 20:37)</a>:</h4>
<p>I am confused what your git state looks like</p>



<a name="222641971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222641971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222641971">(Jan 13 2021 at 20:37)</a>:</h4>
<p>does <code>git push</code> work?</p>



<a name="222642367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222642367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222642367">(Jan 13 2021 at 20:40)</a>:</h4>
<p>Yes, but I need to merge in all of the upstream changes that have taken place since my fork (which has been a while). I guess I'm under the impression that I shouldn't be merging in all of those changes into my PR, but perhaps that's a faulty assumption.</p>



<a name="222642686"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222642686" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222642686">(Jan 13 2021 at 20:43)</a>:</h4>
<p><span class="user-mention" data-user-id="300743">@Sean Chen</span> if they're already in the master branch on the <code>rust-lang/rust</code> repo then it shouldn't matter</p>



<a name="222642977"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222642977" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222642977">(Jan 13 2021 at 20:45)</a>:</h4>
<p>So.. this is fine? <a href="https://github.com/rust-lang/rust/pull/78299/commits/43b9783292af62b5b60e323f5939b9c9a7e9801c">https://github.com/rust-lang/rust/pull/78299/commits/43b9783292af62b5b60e323f5939b9c9a7e9801c</a><br>
<span aria-label="grimacing" class="emoji emoji-1f62c" role="img" title="grimacing">:grimacing:</span></p>



<a name="222643217"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222643217" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222643217">(Jan 13 2021 at 20:47)</a>:</h4>
<p>o.o</p>



<a name="222643227"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222643227" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222643227">(Jan 13 2021 at 20:47)</a>:</h4>
<p>maybe not</p>



<a name="222643242"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222643242" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222643242">(Jan 13 2021 at 20:47)</a>:</h4>
<p>I'd not have expected the diff to change once you updated your branch from master</p>



<a name="222643247"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222643247" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222643247">(Jan 13 2021 at 20:47)</a>:</h4>
<p>Yea, I figured <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="222643384"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222643384" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222643384">(Jan 13 2021 at 20:48)</a>:</h4>
<p>yea i have no idea what that diff means</p>



<a name="222643397"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222643397" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222643397">(Jan 13 2021 at 20:49)</a>:</h4>
<p>oh its submodules</p>



<a name="222643439"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222643439" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222643439">(Jan 13 2021 at 20:49)</a>:</h4>
<p>confused</p>



<a name="222643462"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222643462" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222643462">(Jan 13 2021 at 20:49)</a>:</h4>
<p>Frankly, I think the cleanest way to resolve this is to just close this PR and re-open a new one. There's no real need to keep any of the history pre-merging in Ashley's PR.</p>



<a name="222643542"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222643542" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222643542">(Jan 13 2021 at 20:50)</a>:</h4>
<p>you shouldn't need to close the PR to do that</p>



<a name="222643558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222643558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222643558">(Jan 13 2021 at 20:50)</a>:</h4>
<p>you can always just squash and cleanup the history then force push your branch</p>



<a name="222644068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222644068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222644068">(Jan 13 2021 at 20:54)</a>:</h4>
<p>So combine every commit I've made as part of this PR into a single one? What do you mean by "cleanup the history"?</p>



<a name="222649239"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222649239" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222649239">(Jan 13 2021 at 21:36)</a>:</h4>
<p>Or by squash do you mean get rid of every commit I've made as part of this PR?</p>



<a name="222649295"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222649295" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222649295">(Jan 13 2021 at 21:37)</a>:</h4>
<p>oh, that's what I thought you meant by "not keep any history pre-merging ashley's PR"</p>



<a name="222649357"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222649357" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222649357">(Jan 13 2021 at 21:37)</a>:</h4>
<p>Sure, that works</p>



<a name="222652110"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222652110" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222652110">(Jan 13 2021 at 22:00)</a>:</h4>
<p>When doing the clean up, should I only be removing commits I made from my local commit history, or just get rid of all of them since my first commit?</p>



<a name="222652810"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222652810" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222652810">(Jan 13 2021 at 22:05)</a>:</h4>
<p>not sure what you mean</p>



<a name="222652824"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222652824" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222652824">(Jan 13 2021 at 22:05)</a>:</h4>
<blockquote>
<p>commits I made from my local commit history</p>
</blockquote>



<a name="222652842"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222652842" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222652842">(Jan 13 2021 at 22:05)</a>:</h4>
<p>the only other commit is the merge commit right?</p>



<a name="222652926"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222652926" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222652926">(Jan 13 2021 at 22:06)</a>:</h4>
<p>Right, all the other commits that were merged in</p>



<a name="222652955"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222652955" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222652955">(Jan 13 2021 at 22:06)</a>:</h4>
<p>what I'd do is back out the changes that you didnt make yourself including the merge PR</p>



<a name="222652961"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222652961" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222652961">(Jan 13 2021 at 22:06)</a>:</h4>
<p>so its just your commits</p>



<a name="222652971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222652971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222652971">(Jan 13 2021 at 22:06)</a>:</h4>
<p>then squash that down to 1 commit</p>



<a name="222652993"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222652993" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222652993">(Jan 13 2021 at 22:07)</a>:</h4>
<p>then rebase that on master</p>



<a name="222653131"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222653131" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222653131">(Jan 13 2021 at 22:08)</a>:</h4>
<p>has ashley's change landed on master</p>



<a name="222653187"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222653187" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222653187">(Jan 13 2021 at 22:09)</a>:</h4>
<p>it has</p>



<a name="222653189"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222653189" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222653189">(Jan 13 2021 at 22:09)</a>:</h4>
<p>yay</p>



<a name="222653190"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222653190" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222653190">(Jan 13 2021 at 22:09)</a>:</h4>
<p>okay so yea</p>



<a name="222658603"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222658603" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Ashley Mannix <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222658603">(Jan 13 2021 at 22:52)</a>:</h4>
<p>Another option if it gets too tangled could be to create a new temp branch from <code>master</code>, and cherry pick your commits onto it then force push it as your upstream branch. Submodules can be really nasty to work with... I always land in a mess with them <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="222658646"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222658646" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222658646">(Jan 13 2021 at 22:52)</a>:</h4>
<p>same</p>



<a name="222662261"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662261" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662261">(Jan 13 2021 at 23:31)</a>:</h4>
<p>All right, Jane and I were just trying to work through my screw up, but to no avail. I'm gonna go with the nuclear option and close this PR and re-open a new one. I don't care to keep any of the history pre-Ashley's merged PR.</p>



<a name="222662274"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662274" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662274">(Jan 13 2021 at 23:31)</a>:</h4>
<p>I don't think it was your screwup fwiw</p>



<a name="222662307"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662307" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662307">(Jan 13 2021 at 23:32)</a>:</h4>
<p>its just git</p>



<a name="222662334"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662334" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662334">(Jan 13 2021 at 23:32)</a>:</h4>
<p>combination of long lived branch, multiple merge commits, + submodules being updated between those merge commits</p>



<a name="222662335"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662335" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662335">(Jan 13 2021 at 23:32)</a>:</h4>
<p>Haha, thanks for the sentiment, but I'm sure I had a part to play <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="222662341"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662341" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662341">(Jan 13 2021 at 23:32)</a>:</h4>
<p>i mean, i have no idea what you should have done differently</p>



<a name="222662362"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662362" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662362">(Jan 13 2021 at 23:32)</a>:</h4>
<p>maybe the rustc dev guide has suggestions</p>



<a name="222662367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662367">(Jan 13 2021 at 23:32)</a>:</h4>
<p>ill check</p>



<a name="222662383"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662383" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662383">(Jan 13 2021 at 23:33)</a>:</h4>
<p>I think I should have rebased on top of Ashley's PR?</p>



<a name="222662443"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662443" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662443">(Jan 13 2021 at 23:33)</a>:</h4>
<p><a href="https://rustc-dev-guide.rust-lang.org/git.html#quick-note-about-submodules">https://rustc-dev-guide.rust-lang.org/git.html#quick-note-about-submodules</a></p>



<a name="222662521"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662521" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662521">(Jan 13 2021 at 23:34)</a>:</h4>
<p>the "if you run into an error like this you did nothing wrong" bit at the end has me thinking you did nothing wrong</p>



<a name="222662529"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662529" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662529">(Jan 13 2021 at 23:34)</a>:</h4>
<p>lolol</p>



<a name="222662540"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662540" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662540">(Jan 13 2021 at 23:34)</a>:</h4>
<p>apparently there's a work around here</p>



<a name="222662544"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662544" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662544">(Jan 13 2021 at 23:34)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/77620#issuecomment-705228229">https://github.com/rust-lang/rust/issues/77620#issuecomment-705228229</a></p>



<a name="222662602"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662602" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662602">(Jan 13 2021 at 23:34)</a>:</h4>
<p>i have no idea what that does</p>



<a name="222662605"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662605" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662605">(Jan 13 2021 at 23:34)</a>:</h4>
<p>spooky</p>



<a name="222662610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662610">(Jan 13 2021 at 23:35)</a>:</h4>
<p>So I needed to run this script: <code>git diff --name-only | while read dir; do cd $dir &amp;&amp; git checkout -f HEAD &amp;&amp; git clean -d -f &amp;&amp; cd -; done</code></p>



<a name="222662617"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662617" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662617">(Jan 13 2021 at 23:35)</a>:</h4>
<p>not sure</p>



<a name="222662623"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662623" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662623">(Jan 13 2021 at 23:35)</a>:</h4>
<p>but lets try</p>



<a name="222662644"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662644" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662644">(Jan 13 2021 at 23:35)</a>:</h4>
<p>Haha, sure, why not. I'll try it and report back</p>



<a name="222662671"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662671" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662671">(Jan 13 2021 at 23:35)</a>:</h4>
<p>try doing</p>



<a name="222662676"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222662676" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222662676">(Jan 13 2021 at 23:35)</a>:</h4>
<p><code>git submodule update</code> first</p>



<a name="222663052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222663052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222663052">(Jan 13 2021 at 23:40)</a>:</h4>
<p>bah</p>



<a name="222663054"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222663054" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Sean Chen (he/him) <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222663054">(Jan 13 2021 at 23:40)</a>:</h4>
<p>It doesn't seem to be doing anything</p>



<a name="222663055"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222663055" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222663055">(Jan 13 2021 at 23:40)</a>:</h4>
<p>still not working when i try it</p>



<a name="222663070"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222663070" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222663070">(Jan 13 2021 at 23:41)</a>:</h4>
<p>yea</p>



<a name="222663075"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222663075" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222663075">(Jan 13 2021 at 23:41)</a>:</h4>
<p>just go ahead and remake the PR</p>



<a name="222663096"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222663096" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222663096">(Jan 13 2021 at 23:41)</a>:</h4>
<p>it looks like they encourage always rebasing</p>



<a name="222663105"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/Frames%20Iterator%20PR/near/222663105" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/Frames.20Iterator.20PR.html#222663105">(Jan 13 2021 at 23:41)</a>:</h4>
<p>so i guess in the future just avoid merge commits</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>